[GPU] Periodic Coverity roundup #2840
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
platform:gpu-intel
kealan-barbieri
approved these changes
Mar 7, 2025
atkassen
force-pushed
the
akassen/coverity
branch
2 times, most recently
from
c159499 to
7bd3419
Compare
atkassen
force-pushed
the
akassen/coverity
branch
from
7bd3419 to
5379609
Compare
atkassen
force-pushed
the
akassen/coverity
branch
from
5379609 to
b006734
Compare
dzarukin
approved these changes
Mar 18, 2025
| @@ -133,7 +133,7 @@ class reduce_impl_t { | |||
| auto a_blocks = a.blocks(); | |||
| a_blocks.erase(a_blocks.begin()); | |||
| a = layout_t(a.type(), a.ndims(), 0, a_blocks); | |||
| return find_1d_tile(a, b); | |||
| return find_1d_tile(std::move(a), std::move(b)); | |||
There was a problem hiding this comment.
Looks like the signature of the function can be changed instead:
tensor_t find_1d_tile(const layout_t &a, const layout_t &b) const {
rather than doing moves.
There was a problem hiding this comment.
I can't make that change, as find_1d_tile requires mutable layout_ts.
There was a problem hiding this comment.
I might be wrong, but it looks like when a gets re-created, just a new object will do fine, because the output is a different type and doesn't seem to have a connection with a lifetime (as argument makes a copy of it).
atkassen
force-pushed
the
akassen/coverity
branch
6 times, most recently
from
7ce3826 to
f184df4
Compare
atkassen
force-pushed
the
akassen/coverity
branch
from
f184df4 to
89155b5
Compare
|
make test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses most low severity Coverity hits for GPU and GEMM components.